[vcs] add organization and vendor name VCS attributes #1997
Conversation
|
Content-wise it looks good to me. |
afonsonf
force-pushed
the
1452-add-organization-and-vendor-name-to-vcs-attributes
branch
from
ff5a94d to
69e67f8
Compare
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
afonsonf
force-pushed
the
1452-add-organization-and-vendor-name-to-vcs-attributes
branch
from
69e67f8 to
3b78025
Compare
model/vcs/metrics.yaml
Outdated
There was a problem hiding this comment.
Do we want to recommend these metrics have those attributes on them, or do we want to say they are opt in?
| examples: | ||
| [ | ||
| "my-org", | ||
| "myteam", |
There was a problem hiding this comment.
I hadn't thought of owner as a team name. I think service.namespace can be considered a team name as well. I'd be fine w/ owner being a team name I think, but also I'd add maybe a group/subgroup level of ownership. Or business unit as an example? Curious to know your thoughts.
| "myteam", | |
| "myteam", |
There was a problem hiding this comment.
the myteam was one of the examples in the issue, is service.namespace a new attribute to be added to vcs?
I added business-unit as an example
Co-authored-by: Adriel Perkins <adriel@adrielperkins.com>
…dor-name-to-vcs-attributes
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
Fixes #1452
Changes
Add organization and vendor name to VCS attribute list
Merge requirement checklist
[chore]